First CSS Site [Archive]

Zaiah

November 15th, 2007, 10:54 AM

Hi. This is my first CSS site and I am really happy that I finally even tried to create a full CSS site. Could have saved myself a lot of heartache in the past. A tables version of the site is currently up at http://www.bodybalanceliving.com and the CSS version is here http://www.bodybalanceliving.com/test a few of the pages are incomplete. But I would really like a critique on it so far. The client likes the layout and colors but I am not happy with them. So any advice that could be given in this area or regarding the code would be appreciated. Please don't hold back!

Thanks

Zaiah

November 15th, 2007, 01:33 PM

Hi. This is my first CSS site and I am really happy that I finally even tried to create a full CSS site. Could have saved myself a lot of heartache in the past. A tables version of the site is currently up at http://www.bodybalanceliving.com and the CSS version is here http://www.bodybalanceliving.com/test a few of the pages are incomplete. But I would really like a critique on it so far. The client likes the layout and colors but I am not happy with them. So any advice that could be given in this area or regarding the code would be appreciated. Please don't hold back!

Thanks

COME ON PEOPLE! SOME KIND OF FEEDBACK WOULD BE NICE. EVEN IF YOU DON"T LIKE IT :)

simplistik

November 15th, 2007, 03:25 PM

Well, I don't like the design, but since you're more interested in the code aspect of it here's what I got ;)

it's HTML 4.01 and should be XHTML (not that it's that big a deal), HOWEVER that means you can't use this line
<html xmlns="http://www.w3.org/1999/xhtml"> and you can't close your tags like this />, which will also eliminate other errors.

<script type="text/javascript" src="ieupdate.js"></script>... this should be in the <head> and not declared twice
<center> should not be used

align="justify" shouldn't be used. declare it in your css
get rid of all those
<p> </p> they're an eyesore and not needed
use a js flash object embed method not the <object> and <embed> tags
can't put headers (h1, h2, h3, h4, h5) inside <p> tags

<p class="footerlegal"><span class="footer">©</span> 2007 Body Balance Living Inc. All Rights Reserved</p> kill the <span> from what I can tell it does absolutely nothing...

mattrock23

November 17th, 2007, 03:26 AM

The images of the product look awkward to me, the 3d looks fake, and the nutrition facts panel isn't working for me.

Not many people have flash player 9 yet, I would consider making those things with the lowest nessicary version of flash. I hear that that is a pretty good rule of thumb, only use newer flash player versions if you really need to because updating can be an issue.

I don't know about you but the first question on my mind when I think of nutritious supplements is "What is constipation?" Not just this but some other parts of the content don't make a lot of sence to me.

I hear it's a bad Idea to have text in images. Discrimination against blind people, maybe at least have a more descriptive alt text than what you've got.

I am getting confused as to which version is which since they are interlinked and all, but the shifting navigation could probably be improved, I think that is on the non CSS version.

On the CSS version I expected the icons on the top left to be buttons.

On the non CSS version I expected all of the "Testimonies" Image to be a link like the others of it's kind.

Overall layout and colors look fine to me.

Zaiah

November 17th, 2007, 11:58 AM

Thanks guys! I'm making the changes suggested all of them.

gilemon

November 20th, 2007, 01:14 PM

Looks like the main text is in bold?

the:
"There is a formula I was blessed with that led to the creation of a product that has helped countless people across the country. This formula, along with valuable information I want to share with you, can literally save your life! My passion is to see God’s people restored in every area of their lives – spiritually, mentally, emotionally and in their bodies, the temple."

should not look so bold!

gilemon

November 20th, 2007, 01:15 PM

hey special for a weight loss website

Zaiah

November 21st, 2007, 03:46 PM

hey special for a weight loss website

I think I fixed that once I started doing it in CSS. THanks

BoonDock

November 21st, 2007, 04:05 PM

Well, I don't like the design, but since you're more interested in the code aspect of it here's what I got ;)

it's HTML 4.01 and should be XHTML (not that it's that big a deal), HOWEVER that means you can't use this line
<html xmlns="http://www.w3.org/1999/xhtml"> and you can't close your tags like this />, which will also eliminate other errors.

<script type="text/javascript" src="ieupdate.js"></script>... this should be in the <head> and not declared twice
<center> should not be used

align="justify" shouldn't be used. declare it in your css
get rid of all those
<p> </p> they're an eyesore and not needed
use a js flash object embed method not the <object> and <embed> tags
can't put headers (h1, h2, h3, h4, h5) inside <p> tags

<p class="footerlegal"><span class="footer">©</span> 2007 Body Balance Living Inc. All Rights Reserved</p> kill the <span> from what I can tell it does absolutely nothing...

This is all why SIMP is good at what he is good at.

Take notes. :thumb: